Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vue 3 loop #1145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Vue 3 loop #1145

wants to merge 1 commit into from

Conversation

b3bb0
Copy link

@b3bb0 b3bb0 commented Oct 3, 2024

Fix loop in vue 3

Description of the change

in Vue 3: when rollbar is triggered by a throw error from inside a helper or the router
(I suspect also some other odd placed) including the vm variable can generate an infinte loop
The (proxy) data included in vm are not really needed for debug purposes

Allso added new. tiny feature to fire on warnings from vue

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • [x ] All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Fix loop in vue 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollbar in Vue app causes freeze / 100% CPU usage (inf. recursion)
1 participant